Make getKcContext mock return type less narrow

This commit is contained in:
Joseph Garrone 2024-06-05 23:22:00 +02:00
parent c7c9b19853
commit aa8dc1919f
3 changed files with 11 additions and 7 deletions

View File

@ -47,7 +47,9 @@ export function createGetKcContextMock<
>(params: { >(params: {
pageId: PageId; pageId: PageId;
overrides?: DeepPartial<Extract<KcContext, { pageId: PageId }>>; overrides?: DeepPartial<Extract<KcContext, { pageId: PageId }>>;
}): Extract<KcContext, { pageId: PageId }> { // NOTE: We choose to have a return type less precise than Extract<KcContext, { pageId: PageId }> {
// because we want to be able to use the mock just as the real KcContext.
}): KcContext {
const { pageId, overrides } = params; const { pageId, overrides } = params;
const kcContextMock = structuredCloneButFunctions( const kcContextMock = structuredCloneButFunctions(

View File

@ -47,7 +47,9 @@ export function createGetKcContextMock<
>(params: { >(params: {
pageId: PageId; pageId: PageId;
overrides?: DeepPartial<Extract<KcContext, { pageId: PageId }>>; overrides?: DeepPartial<Extract<KcContext, { pageId: PageId }>>;
}): Extract<KcContext, { pageId: PageId }> { // NOTE: We choose to have a return type less precise than Extract<KcContext, { pageId: PageId }> {
// because we want to be able to use the mock just as the real KcContext.
}): KcContext {
const { pageId, overrides } = params; const { pageId, overrides } = params;
const kcContextMock = structuredCloneButFunctions( const kcContextMock = structuredCloneButFunctions(

View File

@ -64,7 +64,7 @@ import { Reflect } from "tsafe/Reflect";
pageId: "login.ftl" pageId: "login.ftl"
}); });
type Expected = Extract<KcContext, { pageId: "login.ftl" }>; type Expected = KcContext;
assert<Equals<typeof got, Expected>>(); assert<Equals<typeof got, Expected>>();
} }
@ -74,7 +74,7 @@ import { Reflect } from "tsafe/Reflect";
pageId: "register.ftl" pageId: "register.ftl"
}); });
type Expected = Extract<KcContext, { pageId: "register.ftl" }>; type Expected = KcContext;
assert<Equals<typeof got, Expected>>(); assert<Equals<typeof got, Expected>>();
} }
@ -84,7 +84,7 @@ import { Reflect } from "tsafe/Reflect";
pageId: "my-custom-page.ftl" pageId: "my-custom-page.ftl"
}); });
type Expected = Extract<KcContext, { pageId: "my-custom-page.ftl" }>; type Expected = KcContext;
assert<Equals<typeof got, Expected>>(); assert<Equals<typeof got, Expected>>();
} }
@ -181,7 +181,7 @@ import { Reflect } from "tsafe/Reflect";
pageId: "login.ftl" pageId: "login.ftl"
}); });
type Expected = Extract<KcContext, { pageId: "login.ftl" }>; type Expected = KcContext;
assert<Equals<typeof got, Expected>>(); assert<Equals<typeof got, Expected>>();
} }
@ -191,7 +191,7 @@ import { Reflect } from "tsafe/Reflect";
pageId: "register.ftl" pageId: "register.ftl"
}); });
type Expected = Extract<KcContext, { pageId: "register.ftl" }>; type Expected = KcContext;
assert<Equals<typeof got, Expected>>(); assert<Equals<typeof got, Expected>>();
} }